Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see humble choice or trove games #161

Closed
Bertaz opened this issue Sep 30, 2021 · 6 comments · Fixed by #162
Closed

Can't see humble choice or trove games #161

Bertaz opened this issue Sep 30, 2021 · 6 comments · Fixed by #162
Labels
bug Something isn't working

Comments

@Bertaz
Copy link

Bertaz commented Sep 30, 2021

Describe the bug
Today I noticed that the plugin stopped showing newer choice months from around June. I relogged in the integration hoping to solve it.
All my choice months and trove games disappeared, I now only have games from keys and drm-free.
I think it's caused by the absence of options in Settings->Features:
image
I reinstalled the plugin from galaxy, installed the latest release from here, nothing worked

Expected behavior
Show all the choice months and the trove

Plugin installed
directly from Galaxy AND manually from your repository releases

Provide logs
HumblePluginLogs.zip

@Bertaz Bertaz added the bug Something isn't working label Sep 30, 2021
@UncleGoogle
Copy link
Owner

UncleGoogle commented Oct 1, 2021

Hello @Bertaz,

check this build please

humblebundle_0.9.5a.zip

You will have to reconnect the plugin.

@Bertaz
Copy link
Author

Bertaz commented Oct 2, 2021

That build works.
It increased considerably the first import times, before it took less than a minute, now it takes a couple of minutes. Not a problem as it happens only after connecting for the first time.

The subscriptions option under Features reappeared and shows all the humble choices, the newest one for some reason is at the bottom with a star:
image
But it doesn't appear in the Subscriptions tab:
image

Also, after a Galaxy restart, the option under Features disappeared as before, but the already loaded subscriptions remained

[…]the absence of options in Settings->Features: image

humblePluginLog.zip

@UncleGoogle
Copy link
Owner

UncleGoogle commented Oct 2, 2021

Ah, ok, so there was a code leftover from what I've tried to achieve to address this issue: #159 locally on my machine.

I mean - I marked the latest subscription with "*" (a workaround for no option to order subscriptions in Galaxy), but there was one more bug when Galaxy asks for this subscription games.
I'll do that later on - if you have any opinions about that - please let me know in corresponding issue.

For now, I'll release the fix for subscriptions.

@UncleGoogle
Copy link
Owner

Before release I need to also check with account that have never subscribed.

So in case it won't happen this week I'm posting beta build here:
humblebundle_0.9.5b.zip

@Bertaz could you check once again? Reconnection needed.

@Bertaz
Copy link
Author

Bertaz commented Oct 5, 2021

Before release I need to also check with account that have never subscribed.

I don't have a never subscribed account, but from #162 I'm guessing you already tested that

@Bertaz could you check once again? Reconnection needed.

Now everything works correctly, except that after a Galaxy restart the option under Features disappears, but the already loaded subscriptions remain:

[…]absence of options in Settings->Features: image


humblePluginLog_5.10.zip

@UncleGoogle
Copy link
Owner

Hey, thanks for the test.

In plugin logs everything looks good, except that after restart Galaxy just do not ask for subscriptions :(

I think it may be related to gogcom/galaxy-integrations-python-api#180 as also get_owned_games is not called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants