Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_owned_games() function not being called when gog galaxy starts for some integrations #180

Open
Pab10Suarez opened this issue Jun 19, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@Pab10Suarez
Copy link

Pab10Suarez commented Jun 19, 2021

Problem
emulators' integrations that use this function to make games appear as installed don't get installed games

Solution
Call the function at the beginning or provide an alternative

@mbanczerowski
Copy link
Contributor

Hi @Pab10Suarez

the problem is known. It should be fixed in upcoming release.

@Pab10Suarez
Copy link
Author

Heya just checking up the new update, so for now i have seen that retroarch integrations are fixed now, but dolphin and gamecube are not (have not looked in this last ones) so there's still a problem but is a big fix (for my use) i'll look in detail soon

@mbanczerowski
Copy link
Contributor

@Pab10Suarez thanks for sharing the outcome. Actually the logic shouldn't be plugin-platform-wise now. If you could redirect me to those plugins' repositories or share plugin and GalaxyClient logs - that would be helpful for further investigation.

@Pab10Suarez
Copy link
Author

for now i've only used wii and ncube and saw this problem, i think it also happens with others plugins for example cemu/wiiu plug in
logs ncube wii problem.zip

@mbanczerowski
Copy link
Contributor

Thanks @Pab10Suarez, could you also attach GalaxyClient.log?

@Pab10Suarez
Copy link
Author

Thanks @Pab10Suarez, could you also attach GalaxyClient.log?

it is there, i didn't put in in the file name sorry

@Pab10Suarez
Copy link
Author

Pab10Suarez commented Sep 21, 2021

Heya just redirecting you to repositories if it's useful here it is
https://github.com/JTNDev/galaxy-integration-wii
https://github.com/JTNDev/galaxy-integration-gc

i don't have the logs but cemu integration has de same problem so probably they use the same method (i don't have this integration but my brother does)
https://github.com/LeonardFiedrowicz/galaxy-integration-cemu

@mbanczerowski
Copy link
Contributor

Ok, I think we're on track. There is non-obvious flow regarding to authorization state. Started to working on refactor for that.

@Pab10Suarez
Copy link
Author

Ok, I think we're on track. There is non-obvious flow regarding to authorization state. Started to working on refactor for that.

thx! i think it's very important

@Pab10Suarez
Copy link
Author

Heya last update fixed wii and gamecube error for me probably fixed others plataforms but i'll need to verify thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants