Added esp_timer to REQUIRES where needed #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EldritchJS would you fix 4.x builds? |
AFAICT just ESP-IDF v4.1.3 breaks the build. I added a check for that version. I would prefer using |
|
Thank you! |
trombik
added a commit
to trombik/esp-idf-lib
that referenced
this pull request
May 25, 2022
by default, fail-fast is true. this means when one job in a matrix fails, all other jobs in the matrix are canceled. this is not useful when you want to know which job, or which combination of target, build_method, and version, is failing. an example is UncleRus#328. UncleRus#328 see Handling failures at: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: fixes #327