Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce release-drafter GitHub Actions workflow #338

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

trombik
Copy link
Collaborator

@trombik trombik commented Jun 6, 2022

this workflow generates a release draft when PRs with a label are merged
into master branch. a PR without a label, and a commit without PR,
will not be included in the draft.

as discussed at:
#334

this workflow generates a release draft when PRs with a label are merged
into `master` branch. a PR without a label, and a commit without PR,
will not be included in the draft.

as discussed at:
UncleRus#334
@trombik
Copy link
Collaborator Author

trombik commented Jun 6, 2022

pr-labeler workflow did not run because my PR is in a fork. fixed in 091dd0d.

@trombik trombik added the ci Continuous integration label Jun 6, 2022
@trombik trombik requested a review from UncleRus June 7, 2022 00:54
@UncleRus
Copy link
Owner

UncleRus commented Jun 7, 2022

It seems to me that appropriate instructions should be added to the CONTRIBUTING.md, which describe in detail the rules for naming branches.

@trombik
Copy link
Collaborator Author

trombik commented Jun 7, 2022

@UncleRus
Copy link
Owner

UncleRus commented Jun 7, 2022

No, it's not. It only talks about bugfixes, but what about features, docs, or ci updates?

@trombik
Copy link
Collaborator Author

trombik commented Jun 7, 2022

@UncleRus would you please review the updates?

@UncleRus
Copy link
Owner

UncleRus commented Jun 8, 2022

Awesome. Thank you!

@UncleRus UncleRus merged commit 0ea470a into UncleRus:master Jun 8, 2022
@trombik trombik deleted the ci-release-drafter branch June 8, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants