Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableSelection should be avoided. #136

Open
martinviolet88 opened this issue Mar 20, 2023 · 2 comments
Open

disableSelection should be avoided. #136

martinviolet88 opened this issue Mar 20, 2023 · 2 comments

Comments

@martinviolet88
Copy link

The use of disableSelection should be avoided, when using inline editting(https://github.com/symbiote/silverstripe-gridfieldextensions) the function prevents selecting text and textareafields.
https://api.jqueryui.com/disableselection/

Schermafbeelding 2023-03-20 om 18 48 23

"
Caveat emptor: .disableSelection() is actually harmful on some browsers, as it prevents clicking active elements (e.g. textareas) inside the sortable.

Firefox 33.1 for Mac OS X (Yosemite): .disableSelection() prevents clicking on embedded textarea; doesn't seem to have any effect otherwise (i.e. it is still impossible to select text with the mouse in the sortable if omitted)
Chrome 39.0.2171.71 (64-bit) for Mac OS X: .disableSelection() seems to have no effect whatsoever.
"

@UndefinedOffset
Copy link
Owner

This can be turned off by setting the 2nd parameter to new GridFieldSortableRows() to false. That said I'll add this to the list to default it to false in a future release.

@martinviolet88
Copy link
Author

Thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants