Remove GMS 2.3 checks for profile mode and GMS 2.3 warning upon loading #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove GMS 2.3 checks for profile mode and GMS 2.3 warning upon loading
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Jun 25, 2022
Comment on lines
+968
to
+971
| /*if (data.GMS2_3 && SettingsWindow.Warn_About_GMS23) | ||
| { | ||
| this.ShowWarning("This game was built using GameMaker Studio 2.3 (or above). Support for this version is a work in progress, and you will likely run into issues decompiling code or in other places.", "GMS 2.3"); | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
This should be removed, not commented out.
Also, if you want to remove the GMS2.3 warning, you should also probably nuke that from the settings as well, as I don't think Warn_About_GMS23 is used anywhere else.
| @@ -113,7 +113,7 @@ public void ReplaceTextInGML(UndertaleCode code, string keyword, string replacem | |||
| string codeName = code.Name.Content; | |||
| GlobalDecompileContext DECOMPILE_CONTEXT = context is null ? new(Data, false) : context; | |||
|
|
|||
| if (Data.ToolInfo.ProfileMode == false || Data.GMS2_3) | |||
| if (Data.ToolInfo.ProfileMode == false) | |||
There was a problem hiding this comment.
You can reduce this to if (!Data.ToolInfo.ProfileMode)
Comment on lines
+233
to
+238
| /* if (data.GMS2_3) | ||
| { | ||
| this.ShowWarning("Profile mode is not currently supported for GameMaker Studio 2.3 games."); | ||
| return; | ||
| } | ||
|
|
||
| */ |
There was a problem hiding this comment.
This should be removed, not commented out.
|
Besides what @Miepee has noticed, I don't see any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove GMS 2.3 checks for profile mode and GMS 2.3 warning upon loading
Description
Remove GMS 2.3 checks for profile mode and GMS 2.3 warning upon loading.
Caveats
I might have missed some checks for profile mode, and there may or may not be reason for that GMS 2.3 warning to still exist.
Notes
Long overdue, similar warnings need to be removed from the scripts.