Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement YYSpine v3 format #1097

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Conversation

nkrapivin
Copy link
Contributor

@nkrapivin nkrapivin commented Oct 28, 2022

Fixes Death's Gambit.

Description

Fixes issue #1095 and adds a bit more comments to the Spine classes.

Renames PNGBlob property of the Spine texture entry class to TexBlob because the Spine data may no longer be a PNG texture, can also be a GameMaker QOI format (not bz2 compressed as for now?).

Caveats

Any scripts or code that used the PNGBlob property of the Spine texture entry class, or thought that Spine textures are de-facto PNG files will not work properly.

Notes

I don't have Death's Gambit win in possession nor do I own Spine legally so I can't really test this.

@nkrapivin
Copy link
Contributor Author

The first commit will probably fail to compile cuz I didn't change the editor xaml cs, second one should be OK

@github-actions
Copy link

github-actions bot commented Oct 28, 2022

Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might wanna add to the PR description that PNGBlob got renamed to TexBlob as that is a breaking change as well.

UndertaleModLib/Models/UndertaleSprite.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleSprite.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleSprite.cs Outdated Show resolved Hide resolved
@nkrapivin
Copy link
Contributor Author

Done. I still suggest using the term GameMaker QOI and not QOI because YoYoGames's implementation of QOI differs from the original spec on GitHub.

@nkrapivin
Copy link
Contributor Author

🤨

@Grossley Grossley merged commit 8bc24cf into UnderminersTeam:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants