Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs fixes and improvements #831

Merged
merged 34 commits into from
Apr 20, 2022
Merged

Conversation

VladiStep
Copy link
Member

@VladiStep VladiStep commented Apr 11, 2022

  1. Refactored and improved all tabs related code.
  2. Fixed crash on the "Welcome!" tab closing.
  3. Implemented tab history.
  4. All tabs that were opened before loading of another game data are closed now (if was loaded successfully).
  5. Tabs scroll bar is removed and replaced with scroll buttons.
  6. Reduced TabController height to cut empty white rectangle.
  7. The "Welcome!" tab close button now doesn't have close button.
  8. Gap between tab title and close button is reduced.
  9. Tab titles are shortened (removed "Editor" in the end).
  10. Tabs scroll buttons are displayed only if it's needed.
  11. Tab title changes on opened object name change.
  12. Tabs are scrolled one by one.
  13. ExportAllRooms.csx saves last opened object, and restores it after execution.
  14. Selected/opened tab shows (scrolls) itself if not visible.
  15. Now, Ctrl+Q closes app, Ctrl+W closes open tab and Ctrl+Shift+W closes all tabs.
  16. Tabs have a context menu (opened with right-click).
  17. Tabs can be reordered with the left mouse key.
  18. Closed tabs can be restored with Ctrl+Shift+T.
  19. Ctrl+Tab switches to the next tab; Ctrl+Shift+Tab switches to the previous one.
  20. Tab value in debugger is displayed as {UndertaleModTool.Tab - {*OpenedObject*}}.
  21. Fixed code saving on tab with different object type switching.

Other changes:

  1. Optimized room list in the "General info".
  2. Added the CompareNumbersConverter.
  3. UndertaleVariable is now UndertaleNamedResource (was UndertaleResource).

@ToughSun14
Copy link

ToughSun14 commented Apr 12, 2022

Suggestion: Modify tabs so that new tabs only open when selected from the right click menu.
Suggestion: When opening a new data package from within an instance of UMT, close any tabs from previous data package

@VladiStep
Copy link
Member Author

@ToughSun14, I've already know about the second suggestion, thank you.
But I didn't understand the first suggestion - what the "right click menu" ?

@ToughSun14
Copy link

@ToughSun14, I've already know about the second suggestion, thank you. But I didn't understand the first suggestion - what the "right click menu" ?

It's basically what it is: the little menu that pops up when you press the right mouse button on an item in the resource list.

@Miepee Miepee mentioned this pull request Apr 16, 2022
3 tasks
@VladiStep VladiStep marked this pull request as ready for review April 16, 2022 22:19
@VladiStep VladiStep marked this pull request as draft April 17, 2022 11:31
@VladiStep VladiStep marked this pull request as ready for review April 17, 2022 12:30
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
@Miepee
Copy link
Contributor

Miepee commented Apr 17, 2022

Also from testing:

  • I suppose once a tab has been opened once, there isn't a way to cache it so that opening it later takes less time? Opening a huge room for example in a tab, switching to another tab, and then back to the room again will cause a huge loading times and will treat it basically as if the room has been opened the first time.
  • Code entries still have the issues nyako mentioned in the discord server/github: When you have a code entry open, and you switch to another tab to quickly search for references or similar and then go back, UMT compiles the code entry when you switch back from it, and decompiles it again when you switch back to it. This is a huge hindrance in workflow.

Also different icons for tab closing will come soon:tm:. I don't have a problem with the arrow icons.

@NyakoFox
Copy link
Contributor

I believe those are out of scope for this PR... itd require quite a lot of code changes and should be done separately

@Miepee
Copy link
Contributor

Miepee commented Apr 17, 2022

Yeah probably. Wanted to mention them nonetheless so that no one thinks that tabs won't have any issues after this PR.

@Grossley Grossley merged commit 5150869 into UnderminersTeam:master Apr 20, 2022
@VladiStep VladiStep deleted the tabsFixes branch April 20, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants