Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite origin fixes (and more) #884

Merged
merged 12 commits into from
May 4, 2022

Conversation

VladiStep
Copy link
Member

@VladiStep VladiStep commented May 3, 2022

Room editor changes:

  1. Position of rotated/scaled GameObject and SpriteInstance is now properly displayed.
  2. Sprite origin fields in the sprite editor now work (with sprite origin wrappers).
  3. Added descriptions to some properties (and modified existing).
  4. Removed redundant converters: ObjCenterXConverter, ObjCenterYConverter and ObjXOffsetConverter.
  5. Added NegateNumberConverter.
  6. Suppressed Bitmap-related warnings in "UndertaleCachedImageLoader.cs" and replaced with TODO.
  7. "Backgrounds & tile sets" item title changes to "Tile sets" on GMS 2 games.
  8. Fixed bug that prevented adding sprite to a new sprite instance.
  9. New sprite instances have unique names ("graphic_XXXXXXXX", as in GameMaker Studio: 2).
  10. Tiles are now properly updating on their sprite change.
  11. Removed GetBGColorLayer() and integrated its contents into BGColorLayer.

Closes #623

@VladiStep VladiStep marked this pull request as ready for review May 3, 2022 20:39
@VladiStep VladiStep changed the title Sprite origin fixes Sprite origin fixes (and more) May 3, 2022
Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt have time to review everything right now, will review more later

UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
VladiStep and others added 2 commits May 4, 2022 11:50
Co-authored-by: Miepee <38186597+Miepee@users.noreply.github.com>
Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of reviews

UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleRoom.cs Show resolved Hide resolved
UndertaleModLib/Models/UndertaleSprite.cs Show resolved Hide resolved
UndertaleModLib/Models/UndertaleSprite.cs Outdated Show resolved Hide resolved
UndertaleModLib/Models/UndertaleSprite.cs Show resolved Hide resolved
UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs Outdated Show resolved Hide resolved
VladiStep and others added 3 commits May 4, 2022 13:15
@Grossley Grossley merged commit 14103cd into UnderminersTeam:master May 4, 2022
@VladiStep VladiStep deleted the spriteOriginFixes branch May 4, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the origin of Deltarune Chapter 2 sprites saves the changes, but doesn't affect anything in-game
3 participants