More room editor changes. #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic "GenerateRandomName()" method to |SpriteInstance"
…on game data save; updated "AddObjectCopy()" so that it can insert the object
…moved next to "...MouseDown()"
1) Room editor now binds to GMS 2 room layer list without the "LayerFlattenerConverter".
2) Following layer properties are now properly working/displayed: depth, offset, visibility.
3) When layer is selected, all its object will also flash.
4) New layer is visible by default.
5) Fixed adding/removing layers.
6) Fixed saving data with newly created layers ("AssetsData.NineSlices").
7) Depth of new layer automatically increases.
8) "VisualUpwardSearch()" and "FindNearestParent()" methods of "MainWindow" are public.
9) Added "Layer.ToString()" override for ease of debugging.
10) "CanvasWithDict" class has been refactored to "LayerCanvas".
1) Layer list will rearrange on layer depth change. 2) If layers of opened room are not depth-ordered, it will be suggested to rearrange them. 3) Removed redundant "BGLayerVisConverter". 4) Following new background layer data properties are properly set: visibility, color. 5) Removed redundant "flashAnimation" resource from the room editor. 6) Flashing animation error message is more precise.
…sh on layer adding/removing
…iles and size larger than room.
VladiStep
force-pushed
the
roomEditorChanges
branch
from
7240897
to
246c1a3
Compare
Miepee
reviewed
May 11, 2022
Miepee
reviewed
May 11, 2022
Miepee
reviewed
May 11, 2022
|
You forgot to note that it fixes #880. Otherwise everything seems fine. |
Co-authored-by: Miepee <38186597+Miepee@users.noreply.github.com>
I've just forgot about my issue. LOL. |
Miepee
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UndertaleBackgroundandUndertaleSpriteitems can be drag-and-dropped to the room (UndertaleSpritewill work only on GMS 2 games).SpriteInstancecopies with auto-generated name ("graphic_XXXXXXXX").SpriteInstance.GenerateRandomName().insertIndexargument toAddObjectCopy()(if defined, it inserts an object to the list).Rectangle_MouseDown()so it usesAddObjectCopy().AssetsData.NineSliceswas null).VisualUpwardSearch()andFindNearestParent()methods ofMainWindowarepublic.Layer.ToString()override for ease of debugging.BGLayerVisConverter.UndertaleRoomRenderer.TileLayerImagestretch mode wasn't specified).Closes #880.
Here's the link to final builds for testing: artifacts