Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements of some names displaying. #954

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

VladiStep
Copy link
Member

@VladiStep VladiStep commented Jun 7, 2022

Description

  1. Fixed displaying of a title of the tab with multiline UndertaleString - only first line will be displayed.
  2. Added 64 character limit for tab titles.
  3. Optimized displaying of UndertaleString names in the "Strings" list - added 256 character limit; newline characters are replaced with spaces.
  4. Fixed "glitchy" scrolling of the list, with non-empty search box.

Closes #953

Caveats

A object name of a tab may not be fully displayed - not everyone may like it.

…tiline string; "tabTitle" argument of "Tab()" works properly
…mit is set to 256, and newlines are replaced with spaces.
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

@Miepee
Copy link
Contributor

Miepee commented Jun 7, 2022

Code review coming soon too.

  • Your check to get rid of newlines doesn't seem to work, as they're (sometimes) still displayed. Personally I prefer this, and think that getting rid of newlines would make this section a lot less readable. The ... is good enough IMO at showing that this is a shader and not fully displayed.
  • Strings with multiline still screw up the title bar.
    image

I was still getting lag when scrolling via scroll bar (not scroll wheel), and don't have previous behaviour in mind right now, but it doesn't feel as if there is less lag than on master.

@VladiStep
Copy link
Member Author

Code review coming soon too.

  • Your check to get rid of newlines doesn't seem to work, as they're (sometimes) still displayed. Personally I prefer this, and think that getting rid of newlines would make this section a lot less readable. The ... is good enough IMO at showing that this is a shader and not fully displayed.
  • Strings with multiline still screw up the title bar.
    image

I was still getting lag when scrolling via scroll bar (not scroll wheel), and don't have previous behaviour in mind right now, but it doesn't feel as if there is less lag than on master.

Could you check what newline character these strings use? \n or \r\n ?

@Miepee
Copy link
Contributor

Miepee commented Jun 7, 2022

They seem to be \r\n

UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
UndertaleModTool/MainWindow.xaml.cs Outdated Show resolved Hide resolved
@Miepee
Copy link
Contributor

Miepee commented Jun 11, 2022

Yeah, ngl the newlines being replaced looks very weird in cases like these:
image

It did fully fix the lag tho, and the other solutions aren't really much better either sooo ¯_(ツ)_/¯

@Grossley Grossley merged commit fb68ccb into UnderminersTeam:master Jun 11, 2022
@VladiStep VladiStep deleted the tabsChanges branch June 13, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Strings" list requires some improvements.
3 participants