Direct loading and saving game data. #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) "BufferBinaryWriter" is replaced with new "FileBinaryWriter" that doesn't use the buffer. 2) Added the chunks type and object index dictionaries for acceleration of "Writing references in parallel..." data saving part. 3) Added "IUndertaleSingleChunk" and "IUndertale(Simple)ListChunk" interfaces. 4) "FindListChunk()" and "SerializeById()" of "UndertaleResourceById" are using the dictionaries. 5) Changed the messages of "UndertaleWriter.Flush()". 6) Some "UndertaleIO.cs" code formatting changes.
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Jun 12, 2022
|
Tested out the Cafe game as well, seemed to load and save fine. |
Miepee
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Game data loading and saving improvements:
FileBinaryReaderandFileBinaryWriterare used for that.So, it's possible to load and save data files that larger than 2 GB.
IUndertaleSingleChunkandIUndertale(Simple)ListChunkinterfaces.ProfileSaveEvent()andUpdateProfile()are running on different thread, so UI won't freeze on MD5 calculation.Other changes:
Caveats
Game data loading and saving is now more depending on disk read/write load - if disk will be used while loading/saving the data, then it will process the data longer.
Notes
Closes #520