Fix/response type migration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Disclaimer: Este PR replica el PR en el proyecto original.)
En un esquema con multiples bases de datos, OIDC Provider puede ser utilizado en más de una base de datos, no únicamente la BD por defecto.
Esto causa errores de migración debido a que la creación de la tabla ResponseType de Client es creada en la base de datos recibida desde el comando de migración, mientras que los datos insertados son creados en la base de datos indicada por el database router.
Dependiendo de la configuración, la tabla puede no existir en la base de datos o puede haber sido ya migrada, resultando en un DatabaseError o un IntegrityError, respectivamente.
En este fix, se agrega el parametro using(db) en la creación de la tabla y en la inserción de ResponseTypes al archivo de migracion
0026_client_multiple_response_types.py. Esto resuelve la ambigüedad cuando existe más de una base de datos.