Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[#76] Minor improvements #97

Merged
merged 2 commits into from
Oct 11, 2018
Merged

[#76] Minor improvements #97

merged 2 commits into from
Oct 11, 2018

Conversation

Kyrrui
Copy link
Contributor

@Kyrrui Kyrrui commented Oct 9, 2018

No description provided.

marekkirejczyk
marekkirejczyk previously approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@marekkirejczyk marekkirejczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments in the code, would be good to fi them before merge.
I put it on approve, feel free to merge yourself.

@Kyrrui Kyrrui mentioned this pull request Oct 10, 2018
Closed
@Kyrrui
Copy link
Contributor Author

Kyrrui commented Oct 10, 2018

@marekkirejczyk For some reason I can no longer merge in the changes after updating.

@alexvandesande
Copy link
Collaborator

@Kyrrui it might be in conflict with the recently merged #100, as both made changes to approve connection screens. Have you checked the latest master?

@Kyrrui
Copy link
Contributor Author

Kyrrui commented Oct 11, 2018

@Kyrrui it might be in conflict with the recently merged #100, as both made changes to approve connection screens. Have you checked the latest master?

The branch is up to date, just needs a accepting review

@marekkirejczyk marekkirejczyk merged commit 6e503f2 into UniLogin:master Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marekkirejczyk marekkirejczyk marekkirejczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kyrrui @alexvandesande @marekkirejczyk