Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infotext Pictures - Update as soon as the public instance is up and running #109

Closed
rpbarczok opened this issue Mar 16, 2022 · 12 comments · Fixed by #134
Closed

Infotext Pictures - Update as soon as the public instance is up and running #109

rpbarczok opened this issue Mar 16, 2022 · 12 comments · Fixed by #134
Assignees
Labels
enhancement New feature or request

Comments

@rpbarczok
Copy link

Just as a reminder: In the infotext pictures are used that still include the shiite subgroups. To prevent confusion on the side of the users we should update them as soon as we have the live version of the visualisation

@rpbarczok rpbarczok added enhancement New feature or request paused This issue is paused, waiting for external input or events. labels Mar 16, 2022
@tutebatti
Copy link
Collaborator

Thanks for the reminder, this is noted already.

@tutebatti
Copy link
Collaborator

@mfranke93 We would probably need to take the screenshots either from the version to be hosted in Berlin or run another testing instance, right?

@tutebatti tutebatti removed the paused This issue is paused, waiting for external input or events. label Mar 16, 2022
@tutebatti
Copy link
Collaborator

I have been able to make screenshots for the startpage, i.e. not for the info texts that should not show anything not included in the public instance.

@tutebatti tutebatti changed the title Infotext Pictures - Update as soon as the application is published Infotext Pictures - Update as soon as the public instance is up and running Mar 17, 2022
@mfranke93
Copy link
Collaborator

We would probably need to take the screenshots either from the version to be hosted in Berlin or run another testing instance, right?

If the Shi'ites should be condensed (and generally no data not in the public version should be visible), then yes.

@tutebatti
Copy link
Collaborator

tutebatti commented Mar 23, 2022

If the Shi'ites should be condensed (and generally no data not in the public version should be visible), then yes.

So yes. :)

@tutebatti
Copy link
Collaborator

I am waiting for feedback regarding the possible base maps in the public version to update the screenshots. Other than that, we could do it now. Here, too, (cf. #7) I wonder if we should make a difference between what will be in the repo and what is shown in the public version.

@mfranke93
Copy link
Collaborator

What would be the advantage of not having the new screenshots in the repo?

@tutebatti
Copy link
Collaborator

There's no advantage in that sense, I'm just thinking of different base maps and also of different data and data structure (in case of the 5-Shiis etc.). If that's not a problem, the screenshots can be the same in both repo and public version.

@mfranke93
Copy link
Collaborator

mfranke93 commented Apr 11, 2022 via email

@tutebatti
Copy link
Collaborator

Since we now use the same map style as before, we do not need to change the screenshots showing maps. However, there are some instances where the three Shiite subgroups are showing. This is not a huge problem, but I would change it soon. Do you, @mfranke93, want to change them or should I do that?

@mfranke93
Copy link
Collaborator

Do you, @mfranke93, want to change them or should I do that?

I would say you do it, and put in a PR.

For the visualization documentation, I added this disclaimer, alongside the map content copyright statement, in the introduction, and that should suffice in my opinion:

The map material visible in the screenshots is copyrighted by © Mapbox and © OpenStreetMap. The screenshots were created using a larger, private dataset, and the shown religious groups and places might differ from those visible in public versions and the public dataset.

@tutebatti
Copy link
Collaborator

For the visualization documentation, I added this disclaimer

That's a very good solution!

I will get to the screenshots soon.

@mfranke93 mfranke93 linked a pull request May 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants