-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infotext Pictures - Update as soon as the public instance is up and running #109
Comments
Thanks for the reminder, this is noted already. |
@mfranke93 We would probably need to take the screenshots either from the version to be hosted in Berlin or run another testing instance, right? |
I have been able to make screenshots for the startpage, i.e. not for the info texts that should not show anything not included in the public instance. |
If the Shi'ites should be condensed (and generally no data not in the public version should be visible), then yes. |
So yes. :) |
I am waiting for feedback regarding the possible base maps in the public version to update the screenshots. Other than that, we could do it now. Here, too, (cf. #7) I wonder if we should make a difference between what will be in the repo and what is shown in the public version. |
What would be the advantage of not having the new screenshots in the repo? |
There's no advantage in that sense, I'm just thinking of different base maps and also of different data and data structure (in case of the 5-Shiis etc.). If that's not a problem, the screenshots can be the same in both repo and public version. |
The way I see it, the software in the repo and the data that is shown
are independent, so the repo does not have to represent either of the
versions that are currently running regarding which religions, data, or
even map layers are shown. So regarding maintainability (see my response
in #7) putting those screenshots in would be best.
…On Mon, Apr 11, 2022 at 01:08:15AM -0700, Florian Jäckel wrote:
There's no advantage in that sense, I'm just thinking of different base
maps and also of different data and data structure (in case of the 5-Shiis
etc.). If that's not a problem, the screenshots can be the same in both
repo and public version.
—
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
You are receiving this because you were mentioned.Message ID:
***@***.***>
References
Visible links
1. #109 (comment)
2. https://github.com/notifications/unsubscribe-auth/ACHQP3UKAPCQTT2IPBZYVFDVEPMW7ANCNFSM5Q3RXZZA
--
Max Franke, M.Sc.
VIS, University of Stuttgart
Universitätsstraße 38
70569 Stuttgart-Vaihingen
Office: 1.438
Phone: +49 711 685 88435
Web: http://go.visus.uni-stuttgart.de/max.franke
|
Since we now use the same map style as before, we do not need to change the screenshots showing maps. However, there are some instances where the three Shiite subgroups are showing. This is not a huge problem, but I would change it soon. Do you, @mfranke93, want to change them or should I do that? |
I would say you do it, and put in a PR. For the visualization documentation, I added this disclaimer, alongside the map content copyright statement, in the introduction, and that should suffice in my opinion:
|
That's a very good solution! I will get to the screenshots soon. |
Just as a reminder: In the infotext pictures are used that still include the shiite subgroups. To prevent confusion on the side of the users we should update them as soon as we have the live version of the visualisation
The text was updated successfully, but these errors were encountered: