Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant breaks if JS selected #153

Closed
fila90 opened this issue Mar 20, 2019 · 13 comments
Closed

Assistant breaks if JS selected #153

fila90 opened this issue Mar 20, 2019 · 13 comments
Labels
bug good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fila90
Copy link

fila90 commented Mar 20, 2019

As title says, If you choose JavaScript as a language and click Next, assistant breaks.
Also for every language align_assignments.txt can't be found.

EDIT
After more exploration, error occurs every time assistant tries to load more content
e.g.
CSS > Indent Size

@Glavin001
Copy link
Member

I can reproduce:

image

Thank you for reporting this issue!

@Glavin001 Glavin001 added bug help wanted Extra attention is needed good first issue Good for newcomers labels Mar 20, 2019
@Glavin001
Copy link
Member

Pull Requests welcome!

@stevenzeck
Copy link
Contributor

That's not good. I'll look into this tonight

@stevenzeck
Copy link
Contributor

stevenzeck commented Mar 20, 2019

Something about react-highlight does not agree with the newer versions of React and/or its supporting packages. So the page breaks when it has code examples to display.

@stevenzeck
Copy link
Contributor

@fila90 please try now

@Glavin001
Copy link
Member

Looks like there's still a problem: https://assistant.unibeautify.com/#/setup

image

@stevenzeck
Copy link
Contributor

@Glavin001 I don't get that error.
Screen Shot 2019-03-20 at 9 09 33 PM

@fila90
Copy link
Author

fila90 commented Mar 21, 2019

Works now, although there's error
Screenshot from 2019-03-21 09-49-18

  1. Is there any simpler/global way to edit some settings?
    e.g. indent_size is set to 2 for all languages, is there a way I can set it once and it applies for every language I selected?

  2. You also have a tiny bug wit .yaml files
    if you toggle an option e.g. jsx_brackets for JSON (??) default => true => default
    yaml config will look like this

JSON
  jsx_brackets: !<tag:yaml.org,2002:js/undefined> '' 

.json config stays pristine.

  1. If you try to install plugin trough VS Code interface, smiley faces aren't parsed properly so you're left of with :zap:

  2. Config for default configuration doesn't work for me, after reboot I get an error saying it can't find the file
    VS Code: 1.32.3
    OS: Pop!_OS 18.10
    "unibeautify.defaultConfig": "/home/ivan/Downloads/unibeautifyrc.yaml"
    UPDATE
    if you omit extension .yaml it works
    UPDATE 2
    for some reason this works now 😅

  3. And one last question (I hope 😁)
    what is an Multiline Ternary in CSS? and why there is not one for Vue? (and other weird combinations of rules and options)

Sorry for writing it all here, if you want I can raise issues separately, but since you're all here 😁

Great tool by the way, I was struggling between prettier and JS-beautify and now I can have both and much more! 🎉 🎉

@stevenzeck
Copy link
Contributor

stevenzeck commented Mar 21, 2019

Ah, it again throws a console error when going through the wizard. Again, when there are code examples that should be showing. Probably because ugly-samples was moved to the @Unibeautify scope.

@stevenzeck stevenzeck reopened this Mar 21, 2019
@stevenzeck
Copy link
Contributor

stevenzeck commented Mar 22, 2019

Ok, it has nothing to do with Highlight. Node's require function is returning more than just the file contents.
screen_shot_2019-03-21_at_7 35 04_pm

@stevenzeck
Copy link
Contributor

OK, now it's really fixed. @fila90 I'll come back to your question in a bit.

@Glavin001
Copy link
Member

Looks good. Great work, @stevenzeck ! 🎉

image

@fila90
Copy link
Author

fila90 commented Mar 24, 2019

wooow 😮
those examples are extremely useful, great job!! 🎉🎉

@fila90 fila90 closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants