Update Unibeautify and add dependencies property #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavin001
requested changes
Apr 5, 2018
package.json
Outdated
| @@ -44,7 +44,7 @@ | |||
| "tslint-clean-code": "^0.2.6", | |||
| "tslint-microsoft-contrib": "^5.0.3", | |||
| "typescript": "^2.7.2", | |||
| "unibeautify": "^0.10.1" | |||
| "unibeautify": "0.11.1" | |||
There was a problem hiding this comment.
Yes it should, the caret must have been removed during the link.
src/index.ts
Outdated
| @@ -1,11 +1,18 @@ | |||
| import { Beautifier, Language, BeautifierBeautifyData } from "unibeautify"; | |||
| import { Beautifier, Language, BeautifierBeautifyData, DependencyType } from "unibeautify"; | |||
| import * as readPkgUp from "read-pkg-up"; | |||
| import options from "./options"; | |||
| const CLIEngine = require("eslint").CLIEngine; | |||
src/index.ts
Outdated
| name: "ESLint", | ||
| package: "eslint", | ||
| } | ||
| ], | ||
| options: { | ||
| JavaScript: options.JavaScript, | ||
| }, |
There was a problem hiding this comment.
Missing change to
beautifier-eslint/src/index.ts
Line 21 in dce2b22
Something like:
beautify(data: BeautifierBeautifyData) {
return new Promise<string>((resolve, reject) => {
const CLIEngine = data.dependencies.get<NodeDependency>("ESLint").package;There was a problem hiding this comment.
There was a problem hiding this comment.
Whoops, I mean:
const { CLIEngine } = data.dependencies.get<NodeDependency>("ESLint").package;
Glavin001
reviewed
Apr 5, 2018
| } else { | ||
| return resolve(data.text); | ||
| return resolve(text); |
There was a problem hiding this comment.
I wonder if we should throw an error here instead? As part of another PR.
Glavin001
approved these changes
Apr 5, 2018
Glavin001
approved these changes
Apr 5, 2018
|
@Glavin001 anything more needed here? |
Glavin001
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16