Switch to new Unibeautify CI Playground API #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavin001
added
enhancement
|
The maintainers of this repository would appreciate it if you could provide more information. |
stevenzeck
reviewed
May 28, 2018
src/Container.tsx
Outdated
| @@ -14,7 +14,7 @@ require("react-github-button/assets/style.css"); | |||
| import ApiClient, { SupportResponse } from "./ApiClient"; | |||
| import { Playground } from "./Playground"; | |||
|
|
|||
| const apiUrl: string = "https://unibeautify-playground-eijdodv3e08v.runkit.sh"; | |||
| const apiUrl: string = "http://ntd6xp2n56.execute-api.us-east-1.amazonaws.com/dev/playground"; | |||
There was a problem hiding this comment.
Good eye! 👀 I was testing to see if it would work locally with http since the localhost server is only http. No dice. Then forgot to fix before pushing 🙄.
|
Probably should review the Node versions Travis builds against. Right now it's using 6 and 10. I would suggest switching 6 to 8 or just adding 8 in there. |
|
Having problems with https://5b0c8b9db13fb1142da4a881--unibeautify-playground.netlify.com/ Chrome shows in Network request's preview: “Failed to load response data” |
|
@szeck87 Ready for testing 😃 |
stevenzeck
approved these changes
May 30, 2018
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.