Show song artists on album screen (and more) #287
Conversation
…verflow for artists
|
Just pushed a commit that puts the download indicator in a WidgetSpan and aligns it to the text. This looks a lot better IMO, do you agree?
|
|
The alignment is still a bit off, but I could have a look in a bit |
|
It's probably because SVG of the icon itself has padding:
Also the indicator looks a bit tiny now imo, but at least it's indeed nicely aligned to text in the same line. |
|
Yeah, it is a bit small. We could just put it back at the side. The Material icons don't really have a good icon for this use case. |
|
Doesn't look much smaller than in Spotify imo, I'd just suggest aligning it to top, since song length won't have characters like
As for moving it back at the side, I'd say favorite indicator would be better suited there rather than download indicator. In an album you could have all songs downloaded (so you don't need a big sign on each song that it's present on device), but only some of them favorited. |
|
Adding 3 to
|
|
It's pretty much perfect with the offset you had :)
|
|
Looks good to me too! The bottom bar of the icon is a liiiitle bit below text, but I didn't notice it until I zoomed in, so that's fine by me.
|
|
That alignment is probably the best we can get, the code looks good so I'm going to merge this |
* SongListTile track artists WIP * ignore artist order * Offset DownloadedIndicator to align with track number, use ellipsis overflow for artists * Pass now played item to FavoriteButton * Use default color for FavoriteButton if not favorited * Add settings option * Replace stars with hearts in favorite buttons * Add favorite button to album and artist screen * Don't show favorite button for genres * Put download indicator in TextSpan, specify size * Align top, add 3 to widget size * Add offset * Remove redundant initState/dispose Co-authored-by: UnicornsOnLSD <44349936+UnicornsOnLSD@users.noreply.github.com>
Fixes #265. By default song artists are hidden if their set matches set of album's artists, but it's configurable (and persists across app restarts, thanks for hint in the other PR about that!).
As discussed in that issue, this PR also reorganizes SongListTile a bit and replaces stars in favorite buttons with hearts. I also added the now a bit more portable favorite button to artist, album and playlist screens.