Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CartoPy required #1159

Closed
dopplershift opened this issue Sep 12, 2019 · 0 comments · Fixed by #1181
Closed

CartoPy required #1159

dopplershift opened this issue Sep 12, 2019 · 0 comments · Fixed by #1181
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should
Milestone
0.11

Comments

@dopplershift
Copy link
Member

So when we merged in the declarative support, we inadvertently made CartoPy a required dependency. On one hand, you can't really make weather maps without CartoPy. On the other, you can do calculations, plot SkewT's, and read files without it. And unlike some other things, CartoPy is compiled and depends on a pretty thick stack of stuff.

I think I'm leaning towards trying to tweak things to go back to CartoPy as optional.

If instead we do keep it as required, we need to actually list it in setup.py. Yet another case where #845 is needed.
@dopplershift dopplershift added Type: Bug Something is not working like it should Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) labels Sep 12, 2019
@dopplershift dopplershift added this to the 0.11 milestone Sep 26, 2019
dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 27, 2019
@dopplershift
BUG: Allow importing without cartopy (Fixes Unidata#1159)
f0d81a3 
This refactors declarative to remove unconditional import of CartoPy.
This includes moving some lookups to functions, taking advantage of
traitlets' support for Instance(str of class name), and making a
conditionally defined default PlateCarree() projection.
@dopplershift dopplershift mentioned this issue Sep 27, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Rearrange CartoPy Imports dopplershift/MetPy
1 participant
@dopplershift