Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setuptools-scm config #1321

Closed
dopplershift opened this issue Feb 13, 2020 · 1 comment · Fixed by #1510
Closed

Update setuptools-scm config #1321

dopplershift opened this issue Feb 13, 2020 · 1 comment · Fixed by #1510
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Milestone
1.0

Comments

@dopplershift
Copy link
Member

It looks like we should be able to only use pyproject.toml to configure setuptools-scm, at least based on this pint pr and the setuptools-scm readme. This would help us get closer to my platonic ideal of a completely minimal setup.py.
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality labels Feb 13, 2020
@dopplershift dopplershift added this to the 1.0 milestone Feb 13, 2020
@dopplershift
Copy link
Member Author

Should also look at from importlib_metadata import version in lieu of pkg_resources.

dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 23, 2020
@dopplershift
MNT: Replace pkg_resources for getting version (Fixes Unidata#1321)
bf4d3a7 
Use stdlib importlib.metadata (or its backport) instead. Also add a
fallback path in getting the version, which fixes Unidata#1201.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 23, 2020
@dopplershift
MNT: Update pyproject.toml for better setuptools_scm support
3f6ccba 
This partly addresses Unidata#1321, by putting our setuptools_scm config in
pyproject.toml. Leave things in setup.py for now, since all of that
properly functioning requires a pretty recent toolchain.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 23, 2020
@dopplershift
MNT: Replace pkg_resources for getting version (Fixes Unidata#1321)
5dbd895 
Use stdlib importlib.metadata (or its backport) instead. Also add a
fallback path in getting the version, which fixes Unidata#1201.
@dopplershift dopplershift mentioned this issue Sep 23, 2020
Merged
3 tasks
dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 23, 2020
@dopplershift
MNT: Replace pkg_resources for getting version (Fixes Unidata#1321)
ef5e1d1 
Use stdlib importlib.metadata (or its backport) instead. Also add a
fallback path in getting the version, which fixes Unidata#1201.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 28, 2020
@dopplershift
MNT: Update pyproject.toml for better setuptools_scm support
cd1b0a5 
This partly addresses Unidata#1321, by putting our setuptools_scm config in
pyproject.toml. Leave things in setup.py for now, since all of that
properly functioning requires a pretty recent toolchain.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Sep 28, 2020
@dopplershift
MNT: Replace pkg_resources for getting version (Fixes Unidata#1321)
b396d86 
Use stdlib importlib.metadata (or its backport) instead. Also add a
fallback path in getting the version, which fixes Unidata#1201.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Remove uses of pkg_resources dopplershift/MetPy
1 participant
@dopplershift