Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunkers motion using pressure-weighted mean instead of normal mean #1361

Closed
aschueth opened this issue Apr 21, 2020 · 6 comments · Fixed by #1679
Closed

Bunkers motion using pressure-weighted mean instead of normal mean #1361

aschueth opened this issue Apr 21, 2020 · 6 comments · Fixed by #1679
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Milestone

Comments

@aschueth
Copy link
Contributor

Revisiting the Bunkers et al. 2000 paper, it appears they specified the method using the non-pressure-weighted mean wind, and the implementation in Metpy uses the pressure weighted mean wind. I was wondering if this was intended and there has been an update to the bunkers estimate, or if it's a bug.

@aschueth aschueth added the Type: Bug Something is not working like it should label Apr 21, 2020
@dopplershift
Copy link
Member

So my memory may be fuzzy, but if the paper specifies non-pressure-weighted mean wind, we missed it. @mwilson14 can you correct me? I don't see anything in original PR or any issues.

@aschueth So how did you notice this? And would you be interested in submitting a fix?

@dopplershift dopplershift added the Area: Calc Pertains to calculations label Apr 25, 2020
@mwilson14
Copy link
Contributor

Good catch @aschueth ! I just read through the paper again and it does specify non-pressure-weighted mean wind.

@dopplershift
Copy link
Member

Well that's a good indication that we should adjust our implementation 😉

@tjturnage
Copy link
Contributor

FYI, I recently talked to Matt Bunkers about this thread and he confirmed that the mean wind should not be pressure-weighted.

@aschueth
Copy link
Contributor Author

I only noticed because I'm messing with different hodographs for my PhD and changing 3-6 km shear while keeping 1-2 constant doesn't change storm motion appreciably which kinda breaks my hypothesis and I was shocked to see that. Digging a bit more I found the pressure-weighted implementation which makes sense if I'm keeping 1-2 constant.

I'd be willing to submit a fix, but I've got a few more pressing matters to do at the moment, so I'm not sure when I'll be able to submit it.

@dopplershift
Copy link
Member

@aschueth Understood, wasn't sure how much you had dug into things. If you get to it great, otherwise when we get around to it we'll post something here so we don't duplicate effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants