Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-pressure weighted bunkers storm motion #1679

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

aschueth
Copy link
Contributor

As I mentioned in issue #1361, the bunkers storm motion was using a pressure weighted mean wind for its calculations, making the output incorrect. I removed the concatenate(mean_pressure_weighted()) function calls and replaced them with the get_layer function and a simple numpy mean in the line below. I used the output to modify the testing function. I was originally going to use the values from sharppy with a larger range of error, however, after a decent amount of testing, I found out they use the 0-6 shear instead of the (0-500m mean wind) - (5500-6000m mean wind) shear.

… calculation and changed the test values accordingly
Base automatically changed from master to main February 22, 2021 22:39
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing the fix. We'll have to do more in the future when we want this to work on grids of data, but I'm pretty sure it didn't work before anyway.

@dopplershift dopplershift added this to the 1.0.1 milestone Mar 13, 2021
@dopplershift dopplershift added Area: Calc Pertains to calculations Type: Bug Something is not working like it should labels Mar 13, 2021
@dopplershift dopplershift merged commit 3713481 into Unidata:main Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bunkers motion using pressure-weighted mean instead of normal mean
2 participants