Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync dependencies in setup.cfg #1839

Closed
dopplershift opened this issue Apr 29, 2021 · 0 comments · Fixed by #1842
Closed

Sync dependencies in setup.cfg #1839

dopplershift opened this issue Apr 29, 2021 · 0 comments · Fixed by #1842
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality
Milestone
1.1.0

Comments

@dopplershift
Copy link
Member

Currently, Minimum lists pandas 0.24 (to be consistent with current minimum xarray 0.14.1), but setup.cfg lists 0.22. These should be matched up, and we should make sure to sync those up and any other dependency changes we make. Going forward, we should do more to make sure those stay synced.

I suppose another option would be to tweak CI to pull the minimums from setup.cfg instead of having a separate file.
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality labels Apr 29, 2021
@dopplershift dopplershift added this to the 1.1.0 milestone Apr 29, 2021
dopplershift added a commit to dopplershift/MetPy that referenced this issue Apr 30, 2021
@dopplershift
CI: Eliminate duplication of minimum versions (Fixes Unidata#1839)
e8d9c78 
Instead of having a separate file (that doesn't get updated by
Dependabot), just read our minimum versions directly from setup.cfg and
use this to generate a Minimum constraint file on CI.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Apr 30, 2021
@dopplershift
CI: Eliminate duplication of minimum versions (Fixes Unidata#1839)
2963ccf 
Instead of having a separate file (that doesn't get updated by
Dependabot), just read our minimum versions directly from setup.cfg and
use this to generate a Minimum constraint file on CI.

This also updates setup.cfg to reflect the current versions from
Minimum.
@dopplershift dopplershift mentioned this issue Apr 30, 2021
Merged
2 tasks
dopplershift added a commit to dopplershift/MetPy that referenced this issue May 3, 2021
@dopplershift
CI: Eliminate duplication of minimum versions (Fixes Unidata#1839)
9f536f0 
Instead of having a separate file (that doesn't get updated by
Dependabot), just read our minimum versions directly from setup.cfg and
use this to generate a Minimum constraint file on CI.

This also updates setup.cfg to reflect the current versions from
Minimum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Reduce duplication in minimum dependencies dopplershift/MetPy
1 participant
@dopplershift