Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAR parser not handling 'FU' code #1951

Closed
dopplershift opened this issue Jul 2, 2021 · 5 comments · Fixed by #1953
Closed

METAR parser not handling 'FU' code #1951

dopplershift opened this issue Jul 2, 2021 · 5 comments · Fixed by #1953
Labels
Area: IO Pertains to reading data Type: Bug Something is not working like it should
Milestone

Comments

@dopplershift
Copy link
Member

I am struggling to have the parser correctly handle smoke (FU) as a sensible weather condition. Parsing

KFLG 252353Z AUTO 27005KT 10SM FU BKN036 BKN085 22/03 A3018 RMK AO2 SLP130 T02220033 10250 20217 55007=

yields NaN for all fields except station ID, date/time, wind direction/speed, and a 10 for sky cover, meaning that the sky cover was not correctly parsed.

If I parse

KSYR 252354Z 18011KT 10SM FEW180 BKN250 27/12 A3012 RMK AO2 SLP193 T02670122 10294 20267 55002 $=

it parses correctly. but if I parse (same METAR, only with the manual addition of smoke)

KSYR 252354Z 18011KT 10SM FU FEW180 BKN250 27/12 A3012 RMK AO2 SLP193 T02670122 10294 20267 55002 $=

it fails as with the FLG example above.

Originally posted by @VORTEXJeff in #643 (comment)

@dopplershift dopplershift added Area: IO Pertains to reading data Type: Bug Something is not working like it should labels Jul 2, 2021
@dopplershift dopplershift added this to the 1.1.0 milestone Jul 2, 2021
@dopplershift
Copy link
Member Author

@VORTEXJeff I've tweaked the parser locally and have it working properly now. I should have a PR up shortly that fixes this.

dopplershift added a commit to dopplershift/MetPy that referenced this issue Jul 2, 2021
Parser was not dealing well with a lot of weather code fields, so
restructure just to look for sequences of any of those codes.
@VORTEXJeff
Copy link

VORTEXJeff commented Jul 2, 2021 via email

dopplershift added a commit to dopplershift/MetPy that referenced this issue Jul 7, 2021
Parser was not dealing well with a lot of weather code fields, so
restructure just to look for sequences of any of those codes.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Jul 12, 2021
Parser was not dealing well with a lot of weather code fields, so
restructure just to look for sequences of any of those codes.
dopplershift added a commit to dopplershift/MetPy that referenced this issue Aug 6, 2021
Parser was not dealing well with a lot of weather code fields, so
restructure just to look for sequences of any of those codes.
@VORTEXJeff
Copy link

VORTEXJeff commented Aug 24, 2022 via email

@dopplershift
Copy link
Member Author

@VORTEXJeff support-thredds@unidata.ucar.edu is probably the right place for this. The short answer is we moved servers and have been unable to get the venerable netcdf-perl built and running on that machine, so that data is pretty much gone. My suggestion would be to rely on the text products on thredds-dev (though I'm working right now on getting those on our production thredds.ucar.edu machine) and use something like MetPy to parse. Apologies for the inconvenience.

@VORTEXJeff
Copy link

VORTEXJeff commented Aug 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IO Pertains to reading data Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants