Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixing_ratio not quite right #275

Closed
dopplershift opened this issue Dec 6, 2016 · 0 comments
Closed

mixing_ratio not quite right #275

dopplershift opened this issue Dec 6, 2016 · 0 comments
Assignees
@dopplershift
Labels
Area: Calc Pertains to calculations good first issue Straightforward issues suitable for new and inexperienced contributors to the project Type: Bug Something is not working like it should
Milestone
0.4.3

Comments

@dopplershift
Copy link
Member

The docs for mixing ratio are written generically, as if it would work for the mixing ratio of any gases based on their partial pressures. However, the code is hard-wired to use the constant epsilon, which as the ratio of the molecular weights of dry air and water, is only appropriate for water vapor in dry air. Either:

  1. Make the molecular weight ratio a parameter (defaulting to epsilon)

or

  1. Update the docs to reflect only being appropriate for water vapor in dry air
@dopplershift dopplershift added Area: Calc Pertains to calculations good first issue Straightforward issues suitable for new and inexperienced contributors to the project Type: Bug Something is not working like it should labels Dec 6, 2016
@dopplershift dopplershift modified the milestones: Winter 2017, 0.4.3 Dec 6, 2016
@dopplershift dopplershift self-assigned this Dec 12, 2016
dopplershift added a commit to dopplershift/MetPy that referenced this issue Dec 12, 2016
@dopplershift
BUG: Make mixing_ratio work for the general case (Fixes Unidata#275)
209e350 
mixing_ratio's docstring was written to handle any combination of gases,
but the constant used was hard-wired for water vapor in dry air. Allow
specifying the constant, but default to that same case.
@dopplershift dopplershift mentioned this issue Dec 12, 2016
Merged
dopplershift added a commit to dopplershift/MetPy that referenced this issue Dec 12, 2016
@dopplershift
BUG: Make mixing_ratio work for the general case (Fixes Unidata#275)
79fec0b 
mixing_ratio's docstring was written to handle any combination of gases,
but the constant used was hard-wired for water vapor in dry air. Allow
specifying the constant, but default to that same case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dopplershift dopplershift

Labels
Area: Calc Pertains to calculations good first issue Straightforward issues suitable for new and inexperienced contributors to the project Type: Bug Something is not working like it should
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
1 participant
@dopplershift