Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precipitable Water Bounds #575

Closed
2 tasks done
jrleeman opened this issue Sep 28, 2017 · 2 comments
Closed
2 tasks done

Precipitable Water Bounds #575

jrleeman opened this issue Sep 28, 2017 · 2 comments
Assignees
Labels
Area: Calc Pertains to calculations Hacktoberfest Recommended for the Hacktoberfest event Type: Bug Something is not working like it should
Milestone

Comments

@jrleeman
Copy link
Contributor

jrleeman commented Sep 28, 2017

Pointed out by @brianmapes in Gitter, the current implementation of precipitable_water fails if the sounding data stops before 400 hPa. That's because it's set at the default top of the calculation. Brian also pointed out that the default should be integrating the whole thing. @dopplershift and I concur. Here's a summary of what we need to do:

  • Make the default depth None (i.e. top of sounding) and fix-up that implementation a bit.
  • Update the reference, the exercises in Tsonis feels like it could be replaced.

CC author: @mwilson14

@jrleeman jrleeman added Area: Calc Pertains to calculations Type: Bug Something is not working like it should labels Sep 28, 2017
@jrleeman jrleeman added this to the 0.6.1 milestone Sep 28, 2017
@jrleeman jrleeman added the Hacktoberfest Recommended for the Hacktoberfest event label Sep 28, 2017
@mwilson14
Copy link
Contributor

If I remember correctly we chose the 400 hPa default to be in line with what NSHARP and SharpPY use, but integrating the whole sounding definitely makes more sense now! I'm definitely to hear precipitable_water is being used though!

@dopplershift
Copy link
Member

Closed by #595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Hacktoberfest Recommended for the Hacktoberfest event Type: Bug Something is not working like it should
Projects
None yet
Development

No branches or pull requests

3 participants