Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate mpl.cbook.iterable to numpy.iterable #1045

Merged
merged 1 commit into from Jun 6, 2019
Merged

migrate mpl.cbook.iterable to numpy.iterable #1045

merged 1 commit into from Jun 6, 2019

Conversation

akrherz
Copy link
Contributor

@akrherz akrherz commented May 29, 2019

matplotlib.cbook.iterable was deprecated in Matplotlib 3.1

@dopplershift
Copy link
Member

In general, 👍 on the change and thanks for fixing. I want to understand what’s going on with our tests before merging.

@akrherz
Copy link
Contributor Author

akrherz commented May 30, 2019

I believe the failures are scipy=1.3 issue #1043

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2019

CLA assistant check
All committers have signed the CLA.

@akrherz
Copy link
Contributor Author

akrherz commented Jun 6, 2019

rebased now that the scipy fix is in...

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Not sure what's up with CLA assistant. If everything passes besides Travis on the skewT stuff (and CLA if it doesn't get its act together, we'll merge.)

@dopplershift dopplershift added the Type: Maintenance Updates and clean ups (but not wrong) label Jun 6, 2019
@dopplershift dopplershift added this to the 0.11 milestone Jun 6, 2019
@dopplershift
Copy link
Member

Ah, for some reason CLA assistant created a new CLA for MetPy itself--eliminating that has solved the problem.

@dopplershift dopplershift merged commit 0a4086e into Unidata:master Jun 6, 2019
@dopplershift dopplershift modified the milestones: 0.11, 0.10.1 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants