Units: convert '%' to 'percent' for within the xarray MetPy accessor #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbruick
force-pushed
the
pint_percent
branch
2 times, most recently
from
95207bd
to
67156e9
Compare
kgoebber
requested changes
Jun 10, 2019
metpy/tests/test_xarray.py
Outdated
| @@ -84,6 +84,13 @@ def test_units(test_var): | |||
| assert test_var.metpy.units == units('kelvin') | |||
|
|
|||
|
|
|||
| def test_units_percent(): | |||
| """Test that '%' is converted to 'percent' """ | |||
There was a problem hiding this comment.
Just a few lint issues, need a period of the docstring.
Suggested change
| """Test that '%' is converted to 'percent' """ | |
| """Test that '%' is converted to 'percent'.""" |
metpy/tests/test_xarray.py
Outdated
| def test_units_percent(): | ||
| """Test that '%' is converted to 'percent' """ | ||
| test_var_percent = xr.open_dataset(get_test_data('irma_gfs_example.nc', | ||
| as_file_obj=False))['Relative_humidity_isobaric'] |
There was a problem hiding this comment.
This line is too long...
Suggested change
| as_file_obj=False))['Relative_humidity_isobaric'] | |
| test_var_percent = xr.open_dataset( | |
| get_test_data('irma_gfs_example.nc', | |
| as_file_obj=False))['Relative_humidity_isobaric'] |
this update converts '%' units to 'percent' units within the MetPy xarray accessor. Fixes Unidata#1038.
|
Took care of those lint issues. Should be good to go. |
kgoebber
approved these changes
Jun 11, 2019
dopplershift
approved these changes
Jun 11, 2019
dopplershift
added
Area: Xarray
|
Travis failure is just matplotlib. Merging over it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because pint does not support '%' as a unit, this update converts DataArray units that are provided as such to 'percent'.
Fixes #1038.