xarray Coordinate Identification Refactor #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Xarray
dopplershift
approved these changes
Jun 13, 2019
|
Ignoring codeclimate and codacy, since they're wrong IMO. Travis and now AppVeyor (since we have matplotlib 3.1 testing packages for windows) are failing from SkewT, so I'll merge over them. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the systematic coordinate identification is done: previously, the parsing was a part of
parse_cf()on the Dataset accessor, but now, as requested in #1030, it is done on-demand within the DataArray accessor. This allows the coordinate identification features to be used even when someone only has a DataArray and doesn't have a Dataset. These changes also come with a rename of the accessors toMetPyDataArrayAccessorandMetPyDatasetAccessor, and changingcheck_axis()from being a class method on the Dataset accessor to a function in the xarray module (since it is now used several times in calc and interpolate). Since it was an easy change along the way, this PR also sets thekeep_attrsoption onxarray.Dataset.apply()toTrueinparse_cf()to keep the attributes around after parsing.Closes #1030 and closes #1051.