Xarray: Add warning if lat/lon is assumed for projection #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -370,6 +370,8 @@ def parse_cf(self, varname=None, coordinates=None): | |||
| # If we found them, create a lat/lon projection as the crs coord | |||
| if has_lat and has_lon: | |||
| var.coords['crs'] = CFProjection({'grid_mapping_name': 'latitude_longitude'}) | |||
| log.warning('Found lat/lon values, assuming latitude_longitude ' | |||
There was a problem hiding this comment.
Should we mention that we haven't already found a projection, like "No projection found but found lat/lon values"?
There was a problem hiding this comment.
That is already given with the warning that is issued when it doesn't find any valid projection details in the file, just above this part in the code.
try:
proj_var = self._dataset.variables[proj_name]
var = self._dataset.variables[proj_name]
except KeyError:
log.warning('Could not find variable corresponding to the value of '
'grid_mapping: {}'.format(proj_name))There was a problem hiding this comment.
So both warnings would show up if there isn't a CRS but lat/lon values exist - which I think would be the ideal message to users here. @dopplershift do you want any changes to this still?
dopplershift
approved these changes
Jun 19, 2019
dopplershift
added
Area: Xarray
|
Test failures are just SkewT still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple warning that latitude_longitude projection is being assumed if no CRS is found and file has lat/lon variables.
Closes #1039.