Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matplotlib 3.1 fixes #1085

Merged
merged 2 commits into from Jul 5, 2019
Merged

Matplotlib 3.1 fixes #1085

merged 2 commits into from Jul 5, 2019

Conversation

dopplershift
Copy link
Member

This fixes up some issues caused by matplotlib 3.1:

  • Thresholds for images tests--there were some subtle pixel level changes, not clear why, but really minor changes to image results
  • Fix up ticking changes, implementing Update SkewT implementation #987

@dopplershift dopplershift added this to the 0.11 milestone Jul 5, 2019
@dopplershift dopplershift added Area: Plots Pertains to producing plots Type: Maintenance Updates and clean ups (but not wrong) labels Jul 5, 2019
zbruick
zbruick previously approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@zbruick zbruick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to have these issues resolved!

@akrherz
Copy link
Contributor

akrherz commented Jul 5, 2019

👀 travis as I was seeing matplotlib 3.1 failure in metpy.plots.tests.test_util.test_add_timestamp with the stroke path effect of 2 offsetting the generated label positioning by two pixels. Maybe I am seeing a freetype fluke. Crosses fingers here! :)

@dopplershift
Copy link
Member Author

My goal is to cut a 0.10.1 with fixes for this, xarray 0.12.2, and pint 0.9. 0.11 may follow in a couple weeks, but we need to address the MetPy import failure ASAP, since I'm seeing increased reports of problems.

@dopplershift dopplershift modified the milestones: 0.11, 0.10.1 Jul 5, 2019
@dopplershift
Copy link
Member Author

I hate Python 2.

@dopplershift
MNT: Update ticks for SkewT (Fixes Unidata#987)
e18891c 
This updates the implementation for ticks in SkewT based on changes in
matplotlib. This greatly cleans this up, and for some reason, is
necessary with matplotlib 3.1.
@dopplershift
MNT: Update some skewT image test thresholds
4434beb 
This gets the test suite passing with Matplotlib 3.1. Not sure what
changed, but a deep look at the differences only reveals some subtle
changes to just how black the individual tick marks are.
@dopplershift dopplershift merged commit fe9b45a into Unidata:master Jul 5, 2019
@dopplershift dopplershift deleted the matplotlib31 branch July 5, 2019 23:59
@dopplershift dopplershift mentioned this pull request Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbruick zbruick zbruick left review comments

Assignees
No one assigned
Labels
Area: Plots Pertains to producing plots Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dopplershift @akrherz @zbruick