Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LCL in MUCIN calculations if parcel starts below LCL #1109

Merged
merged 1 commit into from Jul 24, 2019

Conversation

zbruick
Copy link
Contributor

@zbruick zbruick commented Jul 23, 2019

Previously, the SBCIN and MUCIN did not match values. This was due to the exclusion of the LCL as a point in the MU profile, while it was included in the SB profile. This PR adds a conditional statement to examine if the most unstable parcel starts below the LCL, and if so, includes the LCL in the profile path. Otherwise, the calculation remains the same as before.

Closes #1108.

@dopplershift dopplershift added Area: Calc Pertains to calculations Type: Bug Something is not working like it should labels Jul 23, 2019
@dopplershift dopplershift added this to the 0.11 milestone Jul 23, 2019
@dopplershift
Copy link
Member

Any chance we were smart enough when making parcel_profile_with_lcl that we could just call that unconditionally?

@zbruick
Copy link
Contributor Author

zbruick commented Jul 23, 2019

Good call - it works and actually yields meaningful positive changes when the LCL is below but close to the base layer of the most unstable parcel.

@dopplershift
Copy link
Member

😌 So glad when things work like I want them to--especially in the thing that I have control over.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Much happier now that we don't need that ugly branch.

@dopplershift dopplershift merged commit ddcbe44 into Unidata:master Jul 24, 2019
@zbruick zbruick mentioned this pull request Sep 3, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface-based and most-unstable CIN don't match when surface parcel is most unstable
2 participants