Rework SkewT tranform #1125
Merged
Rework SkewT tranform #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Plots
|
FWIW I like this PR template seeing it in practice now. |
zbruick
previously approved these changes
Aug 16, 2019
dopplershift
force-pushed
the
fixup-skewt
branch
from
71489ec
to
38d8618
Compare
dopplershift
force-pushed
the
fixup-skewt
branch
2 times, most recently
from
990fcd7
to
13eb1e2
Compare
This changes to apply the skewing last, which fixes some issues caused by working in normalized axes coordinates, like problems when the aspect ratio of the plot wasn't square. This likely paves the way for better handling of data aspect ratio for skewT now too. The key here is to use matplotlib's transform framework to listen for changes to the axes bbox, so that the transform can update to use the proper origin for the skewing.
dopplershift
force-pushed
the
fixup-skewt
branch
from
13eb1e2
to
bdcad95
Compare
|
Codacy is out to lunch. I think this is ready provided everything passes on this rebase. |
zbruick
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This changes to apply the skewing last, which fixes some issues caused by working in normalized axes coordinates, like problems when the aspect ratio of the plot wasn't square. This likely paves the way for better handling of data aspect ratio for skewT now too. The key here is to use matplotlib's transform framework to listen for changes to the axes bbox, so that the transform can update to use the proper origin for the skewing.
Checklist