Deprecate tmpk_out in favor of temperature_out
#1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Aug 16, 2019
There was a problem hiding this comment.
Looks good overall, glad you added the test for the deprecation. Just a couple minor things, including maybe waiting on #1106.
dopplershift
added
Area: Calc
dopplershift
added
the
Type: API Change
|
Rebased on top of #1106, so made use of the new deprecation decorator. Other suggestions were good and did what I wanted to do in my mind but didn't actually write to do. Thanks! |
|
Not sure where codecov went, but this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Deprecate
tmpk_outargument in favor oftemperature_outin theisentropic_interpolationfunction. This will be added to the removal list for 1.0.Checklist