Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unindent section titles in metpy.calc docs to prevent sphinx from failing #1131

Merged
merged 1 commit into from Aug 20, 2019

Conversation

zbruick
Copy link
Contributor

@zbruick zbruick commented Aug 20, 2019

Description Of Changes

Unindent section headers in the MetPy.calc docs, so sphinx doesn't try to import them. Removes warnings in sphinx<2.2.0, removes failure in sphinx=2.2.0.

I still can't believe this was all that was broken.

@dopplershift
Copy link
Member

dopplershift commented Aug 20, 2019

I find it hysterical that it still built the page properly. Honestly, this is the kind of resolution I was expecting. Welcome to dev life. 🤣 😱 😭

@dopplershift dopplershift added Area: Docs Affects documentation Type: Bug Something is not working like it should labels Aug 20, 2019
@dopplershift dopplershift added this to the 0.11 milestone Aug 20, 2019
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a clean doc build.

@zbruick
Copy link
Contributor Author

zbruick commented Aug 20, 2019

I find it hysterical that it still built the page properly. Honestly, this is the kind of resolution I was expecting. Welcome to dev life. 🤣 😱 🤣

This was somehow the most infuriating, but satisfying, solution I've ever come across. It was honestly a last ditch effort to just rebuild the page by sections, and a miracle happened. Yeah, if this isn't an intro to dev life, I don't know what is.

@zbruick
Copy link
Contributor Author

zbruick commented Aug 20, 2019

Good doc build!

@dopplershift
Copy link
Member

Not sure what's up with coverage, but doesn't really matter.

@dopplershift dopplershift merged commit b4dcdf4 into Unidata:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects documentation Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants