New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Layout #1182
Merged
Merged
Update Project Layout #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes the tests, and especially the test images, out of the built wheel files. This addresses part of Unidata#1171.
dopplershift
added
Area: Infrastructure
Pertains to project infrastructure (e.g. CI, linting)
Type: Enhancement
Enhancement to existing functionality
Type: Maintenance
Updates and clean ups (but not wrong)
labels
Sep 30, 2019
This was so GitHub would find our README.rst, but that's not needed any more.
Due to glob, they come out in random order, which with the amount of versions we have is becoming quite apparent.
dopplershift
force-pushed
the
rearrange
branch
2 times, most recently
from
September 30, 2019 01:26
19a3952
to
2726342
Compare
This is supported by PyPI now and is a lot better than RST.
I'm pretty sure this was accidentally committed awhile back. It does not appear to be used, and it's not a useful table otherwise.
This means that when working in the root of the repository, the fact that the current directory is on PYTHONPATH no longer causes metpy to be available. This makes it possible to actually run tests against the installed copy, among other benefits. Addresses part of Unidata#1171.
pytest-flake8 will use the flake8 section now (has for a bit now), so we don't need to have the information duplicated in the pytest config.
There's no need for it to live there and be distributed, so pull it out into a tools/ directory.
These were hiding in docstring examples.
dopplershift
force-pushed
the
rearrange
branch
from
September 30, 2019 02:18
2726342
to
523e058
Compare
zbruick
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll merge over code climate since it's just drudging up old issues due to the filepath change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Infrastructure
Pertains to project infrastructure (e.g. CI, linting)
Type: Enhancement
Enhancement to existing functionality
Type: Maintenance
Updates and clean ups (but not wrong)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The main thrust here is to re-arrange the repository to put tests in a top-level
tests/
directory and move the package source into a top-levelsrc/
directory rather than hangmetpy/
off the repository (both outlined in #1171). This PR also does a bit of maintenance in preparation for the release:README.rst
to markdown and eliminate the top-levelREADME
symlinktest.tbl
--pretty sure this never should have been committed.mailmap
and authors listChecklist