Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further updates to pint master branch compatibility #1250

Merged
merged 3 commits into from Dec 23, 2019
Merged

Further updates to pint master branch compatibility #1250

merged 3 commits into from Dec 23, 2019

Conversation

jthielen
Copy link
Collaborator

@jthielen jthielen commented Dec 20, 2019

Description Of Changes

As mentioned in #1115 (comment), there were a number of issues that came up when running the test suite against the current state of pint's master branch. This PR restores the tests (except those in #1174) back to passing (that is, locally; I'm not sure what's going on with CI).

Checklist

  • Tests added
  • Fully documented

dopplershift
dopplershift previously approved these changes Dec 23, 2019
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on master to get tests passing?

@dopplershift dopplershift added Area: Calc Pertains to calculations Type: Maintenance Updates and clean ups (but not wrong) labels Dec 23, 2019
@dopplershift dopplershift added this to the 0.12 milestone Dec 23, 2019
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants