Update PlotObs for time and station dimension naming #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgoebber
force-pushed
the
update_declare_plots
branch
from
261a571
to
7bbc971
Compare
|
Fixed a few lint issues and removed some accidental commits from the METAR PR that was submitted earlier. |
kgoebber
force-pushed
the
update_declare_plots
branch
from
7bbc971
to
303066b
Compare
Merged
dopplershift
requested changes
Dec 30, 2019
dopplershift
added
Area: Plots
kgoebber
force-pushed
the
update_declare_plots
branch
from
303066b
to
d96b09c
Compare
|
Okay, all updated. Note, I found another small comment that I updated in the declarative around reducing the points for plotting. Only took our '300km' since that was from old code and not always reducing by that specific radius. |
|
Ignoring Codacy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In further testing of reading a data file of METAR with the new parser functionality, the naming convention used in that portion of the code was not captured in the declarative plotting code for the time dimension name and the station dimension name. I've added a few other options and made the loop-up more robust. In addition, I raise an
AttributeErrorif one is not found in the set list. It is relatively easy to remedy if a data frame does not contain the right name by either re-naming a column or creating a new column with one of the names. With the latest additions we cover what I know to be the most common names from the available data sources. This could likely be made more robust in the future, but without a CF convention used for surface observation data, it will be a larger lift.Added some tests to cover new functionality.