fixes read of metar file with bad encoding #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: IO
kgoebber
force-pushed
the
fix_metar_decode
branch
from
73c92f6
to
efdd6f7
Compare
dopplershift
requested changes
Jan 12, 2020
kgoebber
force-pushed
the
fix_metar_decode
branch
from
efdd6f7
to
e06436a
Compare
|
Not sure what’s up with coverage—merging over it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In processing the WMO files that come across the LDM feed I was running into problems where there were certain bytes that were not able to be parsed with the UTF-8 decoding. This PR adds a helper to the open file to escape those bytes and allow the read to continue, specifically
errors='surrogateescape'in_tools.py. I have added a file that contains that problem and added a test to cover the issue.Checklist