Implement basic coordinate/CRS/attribute dataset helpers #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Calc
dopplershift
previously approved these changes
Jan 14, 2020
|
I realized I used some xarray features not released until 0.12.2/0.12.3 in the tests I wrote. Should I go back and rewrite those tests to be compatible with the older version of xarray, or would it be okay to bump the minimum to 0.12.3? |
|
Was just looking at that failure. Unless it's fairly trivial to rewrite, just bump to 0.12.3. |
dopplershift
approved these changes
Jan 14, 2020
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In short, this PR implements #1300. Helpers for adding independent CRS coordinates, building missing horizontal coordinates, and mapping dataset variable attributes are added.
Checklist