Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #1309

Merged
merged 4 commits into from Jan 30, 2020
Merged

Maintenance #1309

merged 4 commits into from Jan 30, 2020

Conversation

dopplershift
Copy link
Member

Description Of Changes

  • Remove unused data file accidentally added to examples
  • Update PyPI classifier to production (correctly this time)
  • Fix broken link to Air Force Skew-T manual

Checklist

@dopplershift dopplershift added this to the 1.0 milestone Jan 23, 2020
@dopplershift dopplershift added Area: Examples Affects examples Type: Maintenance Updates and clean ups (but not wrong) labels Jan 23, 2020
@dopplershift
Copy link
Member Author

Now would be a good time to figure out what we messed up to cause us to lose 100% execution of the test code.

@dopplershift
Copy link
Member Author

@jthielen For future reference, see ac00c5b on the tests. Need to make sure to checkout the exception message outside the raises block.

@dopplershift
BUG: Fix tests
d929656 
Coverage had dropped because we were checking the assertion message
inside the pytest.raises block, rather than outside.
@dopplershift
Copy link
Member Author

Make that d929656.

@dopplershift dopplershift merged commit e71ab0e into Unidata:master Jan 30, 2020
@dopplershift dopplershift deleted the maint branch January 30, 2020 20:20
@jthielen
Copy link
Collaborator

@jthielen For future reference, see ac00c5b on the tests. Need to make sure to checkout the exception message outside the raises block.

Make that d929656.

Got it, thanks! Not sure what I was thinking when writing those tests in the late hours of the night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Examples Affects examples Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dopplershift @jthielen