Convert obs units #1329
Merged
Convert obs units #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgoebber
force-pushed
the
convert_obs_units
branch
2 times, most recently
from
04c3700
to
e6e370f
Compare
kgoebber
force-pushed
the
convert_obs_units
branch
from
e6e370f
to
85c03cc
Compare
kgoebber
force-pushed
the
convert_obs_units
branch
from
85c03cc
to
d22f9cd
Compare
dcamron
requested changes
May 1, 2020
kgoebber
force-pushed
the
convert_obs_units
branch
from
c83e92a
to
71cebd2
Compare
dcamron
previously approved these changes
May 2, 2020
kgoebber
force-pushed
the
convert_obs_units
branch
2 times, most recently
from
f8f06ce
to
87c990f
Compare
dopplershift
requested changes
Aug 8, 2020
src/metpy/plots/station_plot.py
Outdated
| raise ValueError('To convert to plotting units, units must be attached to ' | ||
| 'scalar value being converted.') | ||
|
|
||
| # Strip units, CartoPy transform doesn't like |
There was a problem hiding this comment.
Stripping units shouldn't be necessary, CartoPy only hates them for barbs because it does the extra work of re-projecting the vectors to the transformed coordinate system.
dopplershift
added
Area: Plots
kgoebber
force-pushed
the
convert_obs_units
branch
from
87c990f
to
e03c05f
Compare
dopplershift
approved these changes
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This is an attempt to add an attribute to the declarative syntax to convert units if they are available in data object. So this will work if using the METAR parser or getting upper air observations from the Iowa State archive through Siphon. You can make it work through reading in another manner and adding in the appropriate units, but that takes some real effort with using the Pandas read_csv file.
Thoughts and feedback on the implementation are very welcome. The two current commits cover 1) adding a unit conversion to the
StationPlotclass and 2) adding the plot_units (for scalar quantities) and vector_plot_units (for vector quantities) as attributes toPlotObs.Note: Missed some documentation in this initial PR for
PlotObs().Also did a slight refactor of
PlotObs()to make better use of kwargs - don't know if that helps the code readability, but seemed like a good idea.Checklist