added albers_conical_equal_area projection #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dopplershift , to implement albers, I just copied the code for the lambert method and test. I figured they were both conformal, so the parameters should be the same? Of course there may be more to it than that, but fingers crossed! 😸 |
dopplershift
requested changes
Mar 26, 2020
dopplershift
approved these changes
Mar 27, 2020
dopplershift
added
Area: Projections
jthielen
reviewed
Mar 31, 2020
| attrs = {'grid_mapping_name': 'albers_conical_equal_area', 'standard_parallel': 25} | ||
| crs = CFProjection(attrs).to_cartopy() | ||
| assert isinstance(crs, ccrs.AlbersEqualArea) | ||
| assert crs.proj4_params['lat_1'] == 20 |
There was a problem hiding this comment.
This does not seem to match with the attrs that was set (attrs says 25, this says 20), which is causing test suite to now fail after the fixes I'm working on in #1325. @dopplershift Can I update it there to get tests passing?
There was a problem hiding this comment.
sigh Yes. This is why we need CI working, because I suck at code review.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes