Fix test coverage reporting #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: DevTools
dopplershift
force-pushed
the
fix-coverage
branch
from
1835eca
to
7ed6d4f
Compare
pytest-cov ends up invoking coverage *after* the warning filter, which means coverage starts after many submodules are imported.
dopplershift
force-pushed
the
fix-coverage
branch
from
7ed6d4f
to
9a58244
Compare
This makes it much easier to debug coverage reports.
Trying to eliminate spurious statuses.
dopplershift
force-pushed
the
fix-coverage
branch
from
9a58244
to
a716f7f
Compare
dcamron
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This fixes some issues in our test coverage reporting. In recent versions of pytest, it seems the warning filter is initialized early on. This is a problem for us because that ends up importing
metpy.deprecationbefore pytest-cov has a chance to set up coverage. Thus, currently,metpy,metpy._version,metpy.xarray,metpy.units, andmetpy.deprecationaren't included in the coverage--at least any code that executes at import time. 馃槶 This was really annoying to figure out.Fix this by running coverage manually. As a result, we no longer need to install pytest-cov for CI--it's still fine to use locally (so long as you're not running a warning filter on the
MetpyDeprecationWarning).Checklist