Update metar.py default year, month to keyword-only and None #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrherz
reviewed
Oct 2, 2020
dopplershift
requested changes
Oct 2, 2020
dopplershift
added
Area: IO
`parse_metar_to_dataframe` and `parse_metar_file` relied on defaulting to `datetime.now` sequentially in function signature. Now defaults to `None` and on None sets unspecified year and/or month to same `now`.
dopplershift
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_metar_to_dataframeandparse_metar_filerelied on defaultingyear,monthtodatetime.nowsequentially on import. Now defaults toNoneon import and sets unspecified year and/or month to simultaneousnowon function call. Updated these to keyword-only arguments. Other than that, behaves identically to before, and not sure if we want to discuss any further default changes while already here. e.g. currently if only one of year/month is specified, this will just set the other tonowand carry on with its business.parse_metar_file#1327 (as stated; may have discussion for future METAR parsing changes)