Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing handling of level in PlotObs #1524

Merged
merged 3 commits into from Oct 2, 2020
Merged

Fixing handling of level in PlotObs #1524

merged 3 commits into from Oct 2, 2020

Conversation

dopplershift
Copy link
Member

Description Of Changes

Fixes some issues with the level trait in PlotObs, as noted in #1474:

  • Make None the default
  • Allow passing in level values that do not have units

Checklist

@dopplershift dopplershift added Area: Plots Pertains to producing plots Type: Bug Something is not working like it should labels Oct 2, 2020
@dopplershift dopplershift added this to the 1.0 milestone Oct 2, 2020
@dopplershift dopplershift merged commit 89fd4c0 into Unidata:master Oct 2, 2020
@dopplershift dopplershift deleted the plot-obs-level branch October 2, 2020 20:11
kgoebber
kgoebber reviewed Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@kgoebber kgoebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution. Future proofs while allowing more robust functionality since units are not strictly needed at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgoebber kgoebber kgoebber left review comments

@dcamron dcamron dcamron approved these changes

Assignees
No one assigned
Labels
Area: Plots Pertains to producing plots Type: Bug Something is not working like it should
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

PlotObs specifies Int as option for level
3 participants
@dopplershift @kgoebber @dcamron