Make CartoPy import more robust #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just importing cartopy.feature, explicitly import the two names we need. The result is that on older Cartopy, where Scaler is unavailable, we fail as if CartoPy is not installed rather than failing when creating our map features--which allows users with old CartoPy to still use e.g. SkewT. No tests because there's not obvious way to do so.
dopplershift
added
Area: Plots
dopplershift
added
Area: Infrastructure
dcamron
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Instead of just importing
cartopy.feature, explicitly import the two names we need. The result is that on older Cartopy, whereScaleris unavailable, we fail cleanly (and not interrupting users) as if CartoPy is not installed rather than failing hard when creating our map features--which allows users with old CartoPy to still use e.g. SkewT.No tests because there's no obvious way to do so.
Checklist