BUG: Fix for xarray master #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing keep_attrs=True to Dataset.map on xarray master is causing us to lose needed attribute updates. Not passing it causes the tests to pass on master and seems to work with the last release as well. Tests added to validate other attributes are preserved.
dopplershift
added
Area: Xarray
|
Completely green build! 🎉 |
dcamron
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Passing keep_attrs=True to Dataset.map on xarray master is causing us to
lose needed attribute updates. Not passing it causes the tests to pass
on master and seems to work with the last release as well.
Tests added to validate other attributes are preserved.
Checklist