Enable flake8 simplify #1617
Merged
Enable flake8 simplify #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Infrastructure
dopplershift
force-pushed
the
flake8-simplify
branch
2 times, most recently
from
2fe1bea
to
9932465
Compare
SIM106 is about handling errors early. Right now, it detects a lot of places where we handle errors as an `else` on a chained if, and I disagree about other options being more readable.
It's shorter and clearer what's going on. Found by flake8-simplify.
This has a variety of checks suggesting simpler ways to write certain constructs.
Provoked by flake8-simplify, but also just some general improvements and consolidation.
Found by flake8-simplify
dopplershift
force-pushed
the
flake8-simplify
branch
from
9932465
to
6e81714
Compare
dcamron
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds flake8-simplify to our suite of linting plugins. This catches various miscellaneous things, like those I'm fixing here:
contextlib.suppressto ignore a certain exceptionif 3 == b:)enumerateinstead of incrementing a separate counter in a loopall/any